Refactor getDeviceName() for readability #6319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Pages deployment
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
thornbill
reviewed
Nov 21, 2024
|
thornbill
approved these changes
Jan 6, 2025
Refactored a long if-else into a cleaner, easier to extend mapping
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Renamed deviceMappings to BrowserName and moved it under the appName declaration as requested
|
kevgrig
pushed a commit
to kevgrig/jellyfin-web
that referenced
this pull request
Jan 7, 2025
* Refactor getDeviceName() for readability Refactored a long if-else into a cleaner, easier to extend mapping * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Move BrowserName to the top of the file Renamed deviceMappings to BrowserName and moved it under the appName declaration as requested --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
tylers-username
pushed a commit
to tylers-username/jellyfin-web
that referenced
this pull request
Jan 12, 2025
* Refactor getDeviceName() for readability Refactored a long if-else into a cleaner, easier to extend mapping * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Move BrowserName to the top of the file Renamed deviceMappings to BrowserName and moved it under the appName declaration as requested --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored a long if-else into a cleaner, easier to extend mapping
Changes
Issues
No GitHub issue previously associated, found it on SonarCloud